Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the attribute_extractor to meta_extractor #1399

Merged
merged 4 commits into from
Feb 24, 2021
Merged

Rename the attribute_extractor to meta_extractor #1399

merged 4 commits into from
Feb 24, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Feb 23, 2021 •
edited
Loading

📔 Description

Does what the title says and removes the support for the deprecated #timestamp attribute form entirely.

Should not be merged before the February release!

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

By commit.

@tobim tobim added the maintenance Tasks for keeping up the infrastructure label Feb 23, 2021
@tobim tobim requested a review from a team February 23, 2021 10:58
@mavam mavam added the blocked Blocked by an (external) issue label Feb 23, 2021
@dominiklohmann
Copy link
Member

Before merging, please add a changelog entry.

@tobim tobim removed the blocked Blocked by an (external) issue label Feb 24, 2021
@tobim tobim force-pushed the story/ch22804/meta-extractor branch from d0a7916 to 3be8cff Compare February 24, 2021 12:56
@tobim tobim merged commit d4cd1ff into master Feb 24, 2021
@tobim tobim deleted the story/ch22804/meta-extractor branch February 24, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @dominiklohmann @mavam