Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated code #1374

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

dominiklohmann
Copy link
Member

📔 Description

This PR

  • removes the invalid vast.spawn.importer.ids option,
  • removes the deprecated vast.schema-paths option,
  • disallows spreading a query over multiple arguments, and
  • fixes read_query for single argument queries for the pivot command.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

File-by-file.

This commit
- removes the invalid `vast.spawn.importer.ids` option,
- removes the deprecated `vast.schema-paths` option,
- disallows spreading a query over multiple arguments, and
- fixes read_query for single argument queries for the pivot command.
@dominiklohmann dominiklohmann added maintenance Tasks for keeping up the infrastructure bug Incorrect behavior labels Feb 12, 2021
@dominiklohmann dominiklohmann requested a review from a team February 12, 2021 09:12
CHANGELOG.md Show resolved Hide resolved
libvast/src/system/read_query.cpp Show resolved Hide resolved
@dominiklohmann dominiklohmann merged commit 6044548 into master Feb 12, 2021
@dominiklohmann dominiklohmann deleted the topic/remove-deprecated-stuff branch February 12, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants