Make it easier to reference user defined types in the schema language #1331

tobim · 2021-02-02T14:50:54Z

📔 Description

📝 Checklist

All user-facing changes have changelog entries.
The changes are reflected on docs.tenzir.com/vast, if necessary.
The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Start with "Introduce a common schema file for aliases". This is the user facing change.
Review the unit tests added in "Test extended schema parsing functionality"
Review the rest of the commits in the regular order.

mavam

This is functionality, nice work! I yet have to give it spin locally, but I already went over the code and left a couple of suggestions.

CHANGELOG.md

schema/types/0_common.schema

libvast/test/schema.cpp

libvast/vast/concept/parseable/vast/schema.hpp

The new schema parser makes the schema dsl order-independent. For example: ``` type foo = record{ x: bar #attr2=chirp #attr2=frog #attr3=hog } type bar = int #attr1=cat #attr2=dog ``` Gets accepted and works intuitively. The attributes are merged with the field attributes taking precedence over the attributes from the type. The resolved type of `foo.x` is `int #attr1=cat #attr2=frog #attr3=hog`.

Mostly improved variable and type names. Co-authored-by: Matthias Vallentin <matthias@tenzir.com>

It isn't needed any more for the 2-phase lookup. This also fixes some leftovers from the previous commit integrating some suggested changes from code review.

mavam

Nice work!

tobim added the feature New functionality label Feb 2, 2021

tobim requested a review from a team February 2, 2021 14:50

tobim force-pushed the story/ch21720/common-symbol-table branch from 0c38d22 to 4a0cb8d Compare February 2, 2021 14:53

mavam requested changes Feb 4, 2021

View reviewed changes

tobim force-pushed the story/ch21720/common-symbol-table branch 2 times, most recently from a0a914e to bb1ec78 Compare February 10, 2021 08:24

tobim and others added 16 commits February 11, 2021 18:05

Share a common symbol table when loading schema dirs

67f5ba8

Move the type parser to a dedicated translation unit

f5d71d5

Use the hidden friends idiom for the attribute type

0f809a4

Test extended schema parsing functionality

e56d2c8

Introduce a common schema file for aliases

3b82105

Add a changelog entry

34ba412

Integrate review suggestions

024b3c7

Mostly improved variable and type names. Co-authored-by: Matthias Vallentin <matthias@tenzir.com>

Remove the symbol table parser

c6c4840

It isn't needed any more for the 2-phase lookup. This also fixes some leftovers from the previous commit integrating some suggested changes from code review.

Move the symbol resolver out of the schema parser

5fc3fc5

Unify directory symbols before resolving

788ec68

Renmae 0_common.schema to base.schema

3d2e0fa

Fix unit test

ba1d51b

Fix error propagation

e20d957

Cleanups and comments

95a8139

Improve accuracy in the changelog

33d8056

tobim force-pushed the story/ch21720/common-symbol-table branch from bb1ec78 to 33d8056 Compare February 11, 2021 22:16

Remove obsolete tests

3b5112f

tobim requested a review from mavam February 11, 2021 23:12

mavam approved these changes Feb 12, 2021

View reviewed changes

tobim merged commit ede087b into master Feb 15, 2021

tobim deleted the story/ch21720/common-symbol-table branch February 15, 2021 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make it easier to reference user defined types in the schema language #1331

Make it easier to reference user defined types in the schema language #1331

tobim commented Feb 2, 2021

mavam left a comment

mavam left a comment

Make it easier to reference user defined types in the schema language #1331

Make it easier to reference user defined types in the schema language #1331

Conversation

tobim commented Feb 2, 2021

📔 Description

📝 Checklist

🎯 Review Instructions

mavam left a comment

Choose a reason for hiding this comment

mavam left a comment

Choose a reason for hiding this comment