Load only explicitly specified plugins #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
commented
Jan 15, 2021
dominiklohmann
force-pushed
the
story/ch21758/plugin-explicitly-load
branch
from
e5d5aab
to
3f8133b
Compare
mavam
approved these changes
Jan 15, 2021
This came up during review, and while I generally disagree with not using best practices, I do not hold too strong of an opinion on the matter to not simply make the requested change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This changes the loading of plugins to only consider explicitly specified plugins.
📝 Checklist
🎯 Review Instructions
File-by-file.
This is based on #1282, but this can be reviewed independently.