Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for adding plugin source trees into the build process #1282

Merged
merged 16 commits into from
Jan 15, 2021
Merged

Allow for adding plugin source trees into the build process #1282

merged 16 commits into from
Jan 15, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jan 14, 2021 •
edited
Loading

📔 Description

  • A method to add additional plugin source trees exists, and is utilized for the example plugin (which in turn is moved to the examples/ directory)
  • Plugins can specify test suites that get executed when running the test build target
  • Plugins can specify additional integration test suites

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit. Run locally to verify. Copy the example plugin elsewhere on your system to test for issues.

@dominiklohmann dominiklohmann added feature New functionality bug Incorrect behavior labels Jan 14, 2021
@dominiklohmann dominiklohmann changed the title Allow for adding plugin source trees into VAST build process Allow for adding plugin source trees into the build process Jan 14, 2021
@dominiklohmann
Build plugins with VAST instead of libvast
a2d300c 
Doesn't quite make sense to build plugins when not building VAST, so
let's move it to the appropriate place. Additionally, this fixes a bug
with relative plugin directories.
@dominiklohmann dominiklohmann force-pushed the story/ch21724/plugin-build-process branch from fd6f2e1 to a2d300c Compare January 15, 2021 09:27
@dominiklohmann dominiklohmann marked this pull request as ready for review January 15, 2021 12:50
@dominiklohmann dominiklohmann force-pushed the story/ch21724/plugin-build-process branch from 623e78e to 4d29c83 Compare January 15, 2021 13:46
@dominiklohmann dominiklohmann mentioned this pull request Jan 15, 2021
Merged
3 tasks
mavam
mavam approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I'm ready to use this.

@dominiklohmann dominiklohmann merged commit 125a371 into master Jan 15, 2021
@dominiklohmann dominiklohmann deleted the story/ch21724/plugin-build-process branch January 15, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam