Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that disk budget was not specified as non-string #1278

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Check that disk budget was not specified as non-string #1278

merged 2 commits into from
Jan 13, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jan 12, 2021 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava force-pushed the topic/disk-monitor-args branch 2 times, most recently from 8576057 to e2e2691 Compare January 13, 2021 09:09
mavam
mavam approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me. We've seen that it fixes the issue, so I didn't do extra testing on top.

With a bugfix changelog entry, this is good to go.

@lava lava force-pushed the topic/disk-monitor-args branch 2 times, most recently from 96e13ec to 6339c69 Compare January 13, 2021 10:49
@lava lava merged commit 34a33d4 into master Jan 13, 2021
@lava lava deleted the topic/disk-monitor-args branch January 13, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @mavam