Fix index worker depletion #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
topic/avoid-worker-depletion
branch
from
e03c9a5
to
87bb4fa
Compare
|
@dominiklohmann I added a second change that I thought makes sense. Please have another look. |
dominiklohmann
approved these changes
Dec 11, 2020
libvast/src/system/index.cpp
Outdated
| await_evaluation_maps( | ||
| self, iter->second.expression, actors, | ||
| [=](caf::expected<pending_query_map> maybe_pqm) { | ||
| auto& st = self->state; | ||
| auto drop = [&] { | ||
| self->state.idle_workers.emplace_back(std::move(*worker)); |
There was a problem hiding this comment.
I think we should capture worker = std::move(*worker) in the lambda that we pass to await_evaluation_maps. This code does not need to know about the optional wrapping.
tobim
force-pushed
the
topic/avoid-worker-depletion
branch
from
87bb4fa
to
eb5a16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
A bug that causes the removal of index workers in case of false positive candidate partitions is fixed here.
📝 Checklist