-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement model substitution #1185
Conversation
66abf30
to
c90c170
Compare
c90c170
to
3a0194e
Compare
Nit: Can you move 6df0395 into a separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot get this to work with the instructions provided in the PR. Here's what I tried:
vast start
vast import suricata < M57
vast import zeek < M57
vast export json 'net.connection == <_, _, _, _, _>'
I don't get any results, but was expecting to see all events that contain flow information.
(It also looks like the YAML indentation is off.) |
085d6d4
to
79d26c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now. We are aware of the known deficiencies, and given that this is still marked as experimental features, we can merge this.
But it's nice queries like this now work, which I verified:
vast export json 'net.connection == <_, _, _, _, "icmp">'
Even though they still return a superset of the net.connection
events, this is already really neat. Nice work!
d65bf8a
to
85e019b
Compare
📔 Description
This adds support for models to the
resolve
function of taxonomies. It can substitute records with either named or unnamed fields.Notable supporting changes:
for_each_predicate
helper has been updated to support failure.📝 Checklist
🎯 Review Instructions
It's probably best to go commit-by-commit, but be aware that later commits already contain some naming improvements and functional extensions. The "implement Model substitution" contains the change for the model definitions.