Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfill Deployment Requirements #1175

Merged
merged 10 commits into from
Dec 16, 2020
Merged

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Nov 17, 2020

📔 Description

This PR serves as a merge base for multiple upcoming, related changes regarding the deployment and packaging requirements of VAST. It's done this way because the way CMake must be ran to configure and build VAST will change multiple times over the course of this PR, and we don't want to constantly break master.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann added the refactoring Restructuring of existing code label Nov 17, 2020
cmake/VASTMacDependencyPaths.cmake Outdated Show resolved Hide resolved
cmake/VASTMacDependencyPaths.cmake Outdated Show resolved Hide resolved
cmake/VASTMacDependencyPaths.cmake Outdated Show resolved Hide resolved
@tobim
Copy link
Member

tobim commented Dec 15, 2020

I'm running into a few errors:

CMake Error at CMakeLists.txt:88 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "INTERPROCEDURAL_OPTIMIZATION_RELEASE" is not allowed.


CMake Error at CMakeLists.txt:88 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "CXX_STANDARD" is not allowed.


CMake Error at CMakeLists.txt:88 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "CXX_STANDARD_REQUIRED" is not allowed.


CMake Error at CMakeLists.txt:88 (set_target_properties):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "CXX_EXTENSIONS" is not allowed.


CMake Error at CMakeLists.txt:234 (target_link_libraries):
  INTERFACE library can only be used with the INTERFACE keyword of
  target_link_libraries

@dominiklohmann dominiklohmann force-pushed the epic/deployment-requirements branch 6 times, most recently from ab1c3fc to ba389a4 Compare December 16, 2020 09:48
@dominiklohmann dominiklohmann force-pushed the epic/deployment-requirements branch 6 times, most recently from 4272f61 to 81ba03c Compare December 16, 2020 13:34
@dominiklohmann dominiklohmann marked this pull request as ready for review December 16, 2020 13:44
- Embed xxhash: xxhash is broken under Debian Buster, so we cannot use
  it as an external dependency.
- General cleanup and small fixups.
- Use C++17 for bundled CAF.
@tobim
Copy link
Member

tobim commented Dec 16, 2020

I tested the current state locally and all my setups are working.

Note that it will be best to recreate the build directories. The caf and broker submodules must be initialized in their new locations under libvast/aux/....

@dominiklohmann
Copy link
Member Author

After the approval I only squashed some PRs in the middle.

@dominiklohmann dominiklohmann merged commit 56388bb into master Dec 16, 2020
@dominiklohmann dominiklohmann deleted the epic/deployment-requirements branch December 16, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Restructuring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants