-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fulfill Deployment Requirements #1175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
epic/deployment-requirements
branch
from
December 15, 2020 13:14
cd8ea22
to
7626fd6
Compare
lava
reviewed
Dec 15, 2020
tobim
requested changes
Dec 15, 2020
I'm running into a few errors:
|
dominiklohmann
force-pushed
the
epic/deployment-requirements
branch
6 times, most recently
from
December 16, 2020 09:48
ab1c3fc
to
ba389a4
Compare
dominiklohmann
force-pushed
the
epic/deployment-requirements
branch
6 times, most recently
from
December 16, 2020 13:34
4272f61
to
81ba03c
Compare
tobim
approved these changes
Dec 16, 2020
- Embed xxhash: xxhash is broken under Debian Buster, so we cannot use it as an external dependency. - General cleanup and small fixups. - Use C++17 for bundled CAF.
I tested the current state locally and all my setups are working. Note that it will be best to recreate the build directories. The caf and broker submodules must be initialized in their new locations under |
GCC doesn't enable libsanitizer when targeting musl, the flag must have been silently ignored before.
After the approval I only squashed some PRs in the middle. |
dominiklohmann
force-pushed
the
epic/deployment-requirements
branch
from
December 16, 2020 15:51
edc2fc5
to
cbd1608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR serves as a merge base for multiple upcoming, related changes regarding the deployment and packaging requirements of VAST. It's done this way because the way CMake must be ran to configure and build VAST will change multiple times over the course of this PR, and we don't want to constantly break master.
📝 Checklist
🎯 Review Instructions
n/t