Process schema directories recursively #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type does not contain enough information to infer the semantics.
dominiklohmann
requested changes
Nov 9, 2020
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
dominiklohmann
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
I did not run the code locally, but I read it very thoroughly and I trust that you did actually test it @mavam.
One minor code comment request, other than that this looks good to go to me. Approving already, but please fix the Doxygen comments before merging.
I tested this by running a query with a concept definition in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR enables recursive directory traversal when processing the schema directory.
📝 Checklist
🎯 Review Instructions
Commit-by-commit suits best.