Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make metrics opt-in #1137

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Make metrics opt-in #1137

merged 2 commits into from
Nov 4, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Nov 3, 2020

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

The code change should be obvious, I verified the change locally.

@tobim tobim added the maintenance Tasks for keeping up the infrastructure label Nov 3, 2020
@tobim tobim requested a review from a team November 3, 2020 10:54
dominiklohmann
dominiklohmann requested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git grep disable-metrics still shows some entries.

mavam
mavam approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the application logic and proof-read the documentation.

EDIT: @dominiklohmann, you can take it from here.

@mavam
Copy link
Member

mavam commented Nov 3, 2020 •
edited
Loading

@tobim just a reminder: don't forget the docs.

@tobim tobim merged commit 1ea24e2 into master Nov 4, 2020
@tobim tobim deleted the story/ch20248/opt-in-metrics branch November 4, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @mavam @dominiklohmann