Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default log format less verbose #1107

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Make default log format less verbose #1107

merged 1 commit into from
Oct 22, 2020

Conversation

lava
Copy link
Member

@lava lava commented Oct 21, 2020

Change the default format for logfiles to omit information about
the class, function and thread id. This information adds a lot
of visual noise and little value. In particular the thread id can
easily be confused with a unix time stamp.

Before:

5235076 vast DEBUG actor24 140049658796832 size_t,%20size_t,%20const%20vast.path&,%20vast.system.archive_type,%20caf.actor)<GLOBAL operator() disk_monitor.cpp:114 disk_monitor erasing removed ids from archive

After:

5235076 vast DEBUG actor24 disk_monitor.cpp:114 disk_monitor erasing removed ids from archive

Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I like this change. I'd still like to see @tenzir/backend's opinion on this.

This needs a changelog entry.

libvast/vast/defaults.hpp Outdated Show resolved Hide resolved
@mavam
Copy link
Member

mavam commented Oct 21, 2020

I'm with @dominiklohmann. This is a refreshing change.

@mavam mavam added the maintenance Tasks for keeping up the infrastructure label Oct 21, 2020
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changelog wordsmithing. Not sure about the second sentence, but please use the first one so it's using active over passive voice.

Approving already.

CHANGELOG.md Outdated Show resolved Hide resolved
Change the default format for logfiles to omit information about
the class, function and thread id. This information adds a lot
of visual noise and little value. In particular the thread id can
easily be confused with a unix time stamp.

Before:

    5235076 vast DEBUG actor24 140049658796832 size_t,%20size_t,%20const%20vast.path&,%20vast.system.archive_type,%20caf.actor)<GLOBAL operator() disk_monitor.cpp:114 disk_monitor erasing removed ids from archive

After:

    5235076 vast DEBUG actor24 disk_monitor.cpp:114 disk_monitor erasing removed ids from archive
@lava lava merged commit e5991f1 into master Oct 22, 2020
@lava lava deleted the topic/log-format branch October 22, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants