Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on client-server version mismatch #1098

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Warn on client-server version mismatch #1098

merged 3 commits into from
Oct 16, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Oct 16, 2020

No description provided.

@tobim tobim requested a review from a team October 16, 2020 12:54
dominiklohmann
dominiklohmann requested changes Oct 16, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Just a few nits as individual comments.

Can you add a changelog entry?

libvast/src/system/connect_to_node.cpp Show resolved Hide resolved
libvast/src/system/connect_to_node.cpp Outdated Show resolved Hide resolved
dominiklohmann
dominiklohmann approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this to work as expected locally.

@tobim tobim force-pushed the story/ch19658/warn-on-version-mismatch branch from c2e1450 to 1db59d9 Compare October 16, 2020 15:21
@tobim tobim merged commit 1a988b9 into master Oct 16, 2020
@tobim tobim deleted the story/ch19658/warn-on-version-mismatch branch October 16, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann