Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vast.conf lookup on Linux systems more intuitive #1036

Merged
merged 13 commits into from
Sep 2, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Sep 1, 2020
@dominiklohmann dominiklohmann requested a review from a team September 1, 2020 10:48
vast.conf.example Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
libvast/src/system/configuration.cpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann force-pushed the story/ch19110/vast-conf branch 2 times, most recently from c4ad932 to 7339a6f Compare September 1, 2020 13:21
CHANGELOG.md Outdated Show resolved Hide resolved
@mavam

This comment has been minimized.

@dominiklohmann

This comment has been minimized.

@mavam

This comment has been minimized.

@dominiklohmann

This comment has been minimized.

@mavam

This comment has been minimized.

@dominiklohmann
Copy link
Member Author

This PR was basically remade after our discussion over lunch. Please re-review @tobim @mavam.

CHANGELOG.md Show resolved Hide resolved
vast/vast.cpp Outdated Show resolved Hide resolved
libvast/src/system/configuration.cpp Show resolved Hide resolved
libvast/vast/config.hpp.in Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
libvast/vast/config.hpp.in Outdated Show resolved Hide resolved
@dominiklohmann
Copy link
Member Author

The VAST Docker workflow is failing because a keyserver is down, which is outside of our control. I'll be merging regardless.

@dominiklohmann dominiklohmann merged commit 2e16749 into master Sep 2, 2020
@dominiklohmann dominiklohmann deleted the story/ch19110/vast-conf branch September 2, 2020 14:42
@mavam
Copy link
Member

mavam commented Sep 2, 2020

What about the static build? It seems to fail now on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants