Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown node when component startup fails #1028

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Shutdown node when component startup fails #1028

merged 3 commits into from
Aug 24, 2020

Conversation

mavam
Copy link
Member

@mavam mavam commented Aug 24, 2020

No description provided.

@mavam mavam added the bug Incorrect behavior label Aug 24, 2020
@mavam mavam marked this pull request as ready for review August 24, 2020 11:39
lava
lava approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ideally we'd have a test for this, but of course shutdown-related tests are notoriously hard to write. Maybe we could somehow add a corrupted index/archive state to the repository and try to restore it in one of the integration tests?

libvast/src/system/node.cpp Outdated Show resolved Hide resolved
@mavam
Copy link
Member Author

mavam commented Aug 24, 2020

Maybe we could somehow add a corrupted index/archive state to the repository and try to restore it in one of the integration tests?

Good idea. Let's hold off with that until you've merged the flatbuffer changes. I'll create a follow-up story.

@mavam mavam merged commit a09ba8f into master Aug 24, 2020
@mavam mavam deleted the story/ch18991 branch August 24, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavam @lava