Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow List of Lists and SequenceExample in dict_to_example #6374

Closed
AlexanderLavelle opened this issue Oct 14, 2023 · 3 comments
Closed

Allow List of Lists and SequenceExample in dict_to_example #6374

AlexanderLavelle opened this issue Oct 14, 2023 · 3 comments

Comments

@AlexanderLavelle
Copy link
Contributor

AlexanderLavelle commented Oct 14, 2023

System information

  • TFX Version (you are using): 1.14.0
  • Environment in which you plan to use the feature (e.g., Local
    (Linux/MacOS/Windows), Interactive Notebook, Google Cloud, etc..): Linux (anywhere)
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
The current behavior will not allow a list of lists because list is not an acceptable type (int, str, float). The feature allows a list of lists to be encoder (per sequence modeling etc)

Will this change the current API? How?
The current API will not be affected, although user experience on the read varies -- this function as a standalone with the writer is fine, but a user who does not implement 5689 will not see the Sequences encoded as a result of this modification

Who will benefit with this feature?
Users who want to do sequence modeling whose native data is list of lists or tf.RaggedTensors

Do you have a workaround or are completely blocked by this? :
This is the workaround

Name of your Organization (Optional)

Any Other info.

PR # 6373

@singhniraj08
Copy link
Contributor

@AlexanderLavelle,

I see a PR already attached by you for the feature implementation. We will keep you updated on the PR. Thank you for your contributions.

@github-actions
Copy link
Contributor

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Oct 24, 2023
@github-actions
Copy link
Contributor

This issue was closed due to lack of activity after being marked stale for past 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants