Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement livestream image classification #109

Merged
merged 2 commits into from Jul 24, 2023
Merged

Implement livestream image classification #109

merged 2 commits into from Jul 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2023

No description provided.

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 16, 2023

Hey Duy, would you mind updating the readme to explain what this app does, how to run the model download script (and that it needs to happen), and maybe a little information about how the code is set up/key classes.

Thanks!

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 16, 2023

Alright should just need to run dart format. I also ran into an issue where the camera froze and crashed the app when running from visual studio to Android, but it works fine in Android Studio, so I'm guessing it's more of a setup issue on my side.

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 16, 2023

Can you also update the UI to add a small section at the bottom to show the classifications (normalized as 0.0 -> 1.0) that is more easily visible (like what we have in the Android apps). We can keep it sorted and displaying 3 items consistently rather than changing those options at runtime. Thanks Duy!

@tenkeyless
Copy link

tenkeyless commented Jul 17, 2023

Can you check for memory leak?

I think it is because if inference.run method on tflite.
I've run classification with your code, but I used my own mobileNetV2 with float16.

When I run 6 minute, memory goes up to about 630MB.

CleanShot 2023-07-17 at 16 40 20@2x

When I run 9 minute, memory goes up to about 700MB.

CleanShot 2023-07-17 at 16 43 24@2x

When I run 43 minute, memory goes up to about 2.09GB.

CleanShot 2023-07-17 at 17 17 38@2x

Memory goes up and never go down, even I change it to gallery mode.

I ran that with iPad pro 11 m1 model.

@PaulTR
Copy link
Collaborator

PaulTR commented Jul 17, 2023

Memory issue on iOS being tracked in #110 and outside of the control of the sample app.

@tenkeyless
Copy link

After your comment, I've found out it is outside of the control of the sample app. It happened only iOS.

@ghost ghost requested a review from PaulTR July 20, 2023 02:52
@PaulTR
Copy link
Collaborator

PaulTR commented Jul 24, 2023

LGTM. Thanks Duy!

@PaulTR PaulTR merged commit d457be5 into tensorflow:main Jul 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants