Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Use positional arguments in envd destroy and so on #1075

Open
gaocegege opened this issue Oct 21, 2022 · 3 comments
Open

feat(CLI): Use positional arguments in envd destroy and so on #1075

gaocegege opened this issue Oct 21, 2022 · 3 comments

Comments

@gaocegege
Copy link
Member

gaocegege commented Oct 21, 2022

Description

Now the destroy command does not look great:

envd destroy --name {name}

Expected:

envd destroy {name}

We should wait until urfave/cli#1074 is resolved.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@gaocegege
Copy link
Member Author

Maybe, we should migrate to https://github.com/spf13/cobra

It supports this feature.

@kemingy
Copy link
Member

kemingy commented Dec 23, 2022

Maybe, we should migrate to https://github.com/spf13/cobra

It supports this feature.

LGTM. A huge refactor.

@kemingy
Copy link
Member

kemingy commented Dec 23, 2022

urfave/cli may have better shell-completion (both bash and zsh) support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants