feat: add permission table and create role flyout #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahdcoder
requested changes
Dec 15, 2021
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
packages/cms/pages/settings/roles-and-permissions/roles-and-permissions.tsx
Outdated
Show resolved
Hide resolved
bahdcoder
requested changes
Dec 17, 2021
|
|
||
| const columns = [ | ||
| { | ||
| field: 'role', |
There was a problem hiding this comment.
Field is role and name is Role. Same for members.
| return ( | ||
| <> | ||
| <TableHeading> | ||
| <div> |
There was a problem hiding this comment.
When displaying text, be sure to use EuiText or EuiTitle. In this case, please use a title. The size of the title should be the same as the title of the profile page.
…39/permissions
… into CMS-39/permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.