fix ascii art bug #176
Merged
fix ascii art bug #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installed ascii package throws causes an error to be thrown when a new tensei app is initialized this commit fixes this
bahdcoder
requested changes
Nov 10, 2021
examples/typescript/package.json
Outdated
| @@ -4,7 +4,6 @@ | |||
| "main": "src/index.ts", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@mikro-orm/sqlite": "^4.4.0", | |||
There was a problem hiding this comment.
Past. I think this should still be there actually
|
Also your last commit wasn't in the correct format. You may use yarn commit command to add a new commit of the right format in future |
bahdcoder
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installed ASCII package causes an error
to be thrown when a new Tensei app is initialized
this commit fixes this issue
Please review.
Fixes #160