fix(component): responsive sidebar now closes on backdrop and menu click #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The responsive sidebar initially closes only when the close icon is clicked but now closes once the backdrop is clicked as well as any item on the menu.
bahdcoder
pushed a commit
that referenced
this pull request
Jun 26, 2021
…ick (#121) The responsive sidebar initially closes only when the close icon is clicked but now closes once the backdrop is clicked as well as any item on the menu.
bahdcoder
added a commit
that referenced
this pull request
Jun 26, 2021
* feat(manda): add manda package for generating @tensei/client package Add basic interfaces from resources * feat(manda): add update / insert / sort query order interfaces * feat(sdk): add auth module to sdk generator * chore(sdk): add new sdk package * feat(sdk): add auth api to js sdk * chore(core): format with prettier * feat(sdk): add build script to sdk package * fix(express-session-mikro-orm): fix update query for mongodb (#108) use nativeUpdate instead of persist and flush for session update fix #107 * Fix/publish mongodb login fix (#109) * chore(core): bump package versions to v0.8.5 * v0.8.5 * Fixed the Procedure component bug not adding new items when the enter… (#118) * Fixed the Procedure component bug not adding new items when the enter button is clicked Signed-off-by: Anisat Akinbani <anisatakinbani13@gmail.com> * fix(component): fixed the Procedure component not adding new items when the enter button is clicked Apart from when the button component is clicked on to add new items, the enter button should also be able to do the same which was the purpose of this change. * fix(component): responsive sidebar now closes on backdrop and menu click (#121) The responsive sidebar initially closes only when the close icon is clicked but now closes once the backdrop is clicked as well as any item on the menu. * feat(rest): add core as dependency to rest package * feat(tests): fix passwordless register test in mysql v8.0 * ci(core): run builds only on pull request * test(tests): fix two factor and email confirmation tests Co-authored-by: Anisat Akinbani <52763841+Annysah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The responsive sidebar initially closes only when the close icon is clicked but now closes once the
backdrop is clicked as well as any item on the menu.