Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abci-cli: kvstore should store height #4507

Closed
4 tasks done
erikgrinaker opened this issue Feb 28, 2020 · 0 comments · Fixed by #4509
Closed
4 tasks done

abci-cli: kvstore should store height #4507

erikgrinaker opened this issue Feb 28, 2020 · 0 comments · Fixed by #4509
Assignees
Labels
T:enhancement Type: Enhancement

Comments

@erikgrinaker
Copy link
Contributor

Summary

The abci-cli kvstore application does not appear to store the key height:

$ ./abci-cli kvstore
$ ./build/tendermint node
$ curl -s 'localhost:26657/broadcast_tx_commit?tx="key=value"'
$ curl -s 'localhost:26657/abci_query?data="key"'
{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "response": {
      "code": 0,
      "log": "exists",
      "info": "",
      "index": "0",
      "key": "a2V5",
      "value": "dmFsdWU=",
      "proof": null,
      "height": "0",
      "codespace": ""
    }
  }
}

Problem Definition

When testing, users expect the application to correctly return the height of the key. We should meet this expectation.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant