-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to amino 0.14.1 #2822
update to amino 0.14.1 #2822
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
- Coverage 62.51% 62.31% -0.21%
===========================================
Files 212 212
Lines 17168 17206 +38
===========================================
- Hits 10733 10722 -11
- Misses 5539 5584 +45
- Partials 896 900 +4
|
@@ -58,7 +58,7 @@ | |||
|
|||
[[constraint]] | |||
name = "github.com/tendermint/go-amino" | |||
version = "v0.14.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it kind of weird that this now break dependencies for any downstream application who was still using v0.14.0
. perhaps we should set it to allow v0.14.0
and v0.14.1
, and then the downstream rasp-pi app would just select v0.14.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't block merge, but is a general note about dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we should switch to ^X.Y.Z
or ~X.Y.Z
for most of the dependencies.
Can you redo this using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💠
fixes int overflow that prevent
tendermint
from building on RPi