Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Track and update tendermint changes in privval package #229

Closed
liamsi opened this issue Apr 16, 2019 · 3 comments
Closed

Track and update tendermint changes in privval package #229

liamsi opened this issue Apr 16, 2019 · 3 comments

Comments

@liamsi
Copy link
Contributor

liamsi commented Apr 16, 2019

This issue is to track the changes there and update the KMS accordingly.

@liamsi liamsi changed the title Track and update tendermint changes Track and update tendermint changes in privval package Apr 16, 2019
@tarcieri
Copy link
Contributor

@liamsi do these need to happen prior to the prop 5 upgrade?

@liamsi
Copy link
Contributor Author

liamsi commented Apr 20, 2019

So far only tendermint/tendermint#3351 was merged into the tendermint v0.31 releases (which will be used in the hub). The diff looked like the amino prefixes will change which is in fact not the case. I updated the description above.

The other change (tendermint/tendermint#3370) will make it into tenderment v0.32 and is not necessary for the prop 5 upgrade. @jleni and I want more testing and confidence that the refactoring does work as expected.

@tarcieri
Copy link
Contributor

tarcieri commented Aug 1, 2019

@jleni if there are tendermint-rs changes that still need to happen, can you open a new issue about this at:

https://github.com/interchainio/tendermint-rs

Otherwise closing this as the relevant code has been relocated to the above repo.

@tarcieri tarcieri closed this as completed Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants