instances should be re-created when image_id changes

[yongzhang]

provider version: 1.12
when image_id changed, instances should be re-created instead of "modify":

  ~ tencentcloud_instance.test_vm_tct_cn[0]
      image_id:                                  "img-mzbr88cf" => "img-axq9idj1"

  ~ tencentcloud_instance.test_vm_tct_cn[1]
      image_id:                                  "img-mzbr88cf" => "img-axq9idj1"

  ~ tencentcloud_instance.test_vm_tct_cn[2]
      image_id:                                  "img-mzbr88cf" => "img-axq9idj1"

  ~ tencentcloud_instance.test_vm_tct_eu[0]
      image_id:                                  "img-o77dd2jn" => "img-pi1pale7"

  ~ tencentcloud_instance.test_vm_tct_eu[1]
      image_id:                                  "img-o77dd2jn" => "img-pi1pale7"

  ~ tencentcloud_instance.test_vm_tct_eu[2]
      image_id:                                  "img-o77dd2jn" => "img-pi1pale7"


Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

tencentcloud_instance.test_vm_tct_cn[0]: Modifying... (ID: ins-1vv9a7er)
  image_id: "img-mzbr88cf" => "img-axq9idj1"
tencentcloud_instance.test_vm_tct_eu[2]: Modifying... (ID: ins-003b1pf2)
  image_id: "img-o77dd2jn" => "img-pi1pale7"
tencentcloud_instance.test_vm_tct_eu[0]: Modifying... (ID: ins-09od6vhg)
  image_id: "img-o77dd2jn" => "img-pi1pale7"
tencentcloud_instance.test_vm_tct_eu[1]: Modifying... (ID: ins-o9wbotcw)
  image_id: "img-o77dd2jn" => "img-pi1pale7"
tencentcloud_instance.test_vm_tct_cn[1]: Modifying... (ID: ins-ac71rjd5)
  image_id: "img-mzbr88cf" => "img-axq9idj1"
tencentcloud_instance.test_vm_tct_cn[2]: Modifying... (ID: ins-7kbqea89)
  image_id: "img-mzbr88cf" => "img-axq9idj1"

[likexian]

Hello,
We support reset instance's image, re-create is unnecessary.

[yongzhang]

Well, when users updated image_id, they probably want to re-create instances with the new image, why "unnecessary"?

[likexian]

Re-create instance will change something, for example ip.
For most user, change image is expect as reinstall the system, but not re-create an instance.

[yongzhang]

Re-create instance will change something, for example ip.
For most user, change image is expect as reinstall the system, but not re-create an instance.

I agree with you if user manage instance by UI, but this is terraform, we treat infra as cattle not pets, at least we can have a switch to decide "recreate" or not.

[ausmartway]

李总，这个事情上我同意客户的意见，修改了imageid实际上是要求重新创建。

…

On Thu, 25 Jul 2019 at 19:47, Li Kexian ***@***.***> wrote: Re-create instance will change something, for example ip. For most user, change image is expect as reinstall the system, but not re-create an instance. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/terraform-providers/terraform-provider-tencentcloud/issues/78?email_source=notifications&email_token=AFB357Y7R6ITUDZED6XCXFLQBFZBNA5CNFSM4IGYNWAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Y6ZJI#issuecomment-514976933>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFB357YF7OLBJWJIOG75QH3QBFZBNANCNFSM4IGYNWAA> .

[likexian]

李总，这个事情上我同意客户的意见，修改了imageid实际上是要求重新创建。
[…]

谢谢刘总，我们修改一下。

[likexian]

Re-create instance will change something, for example ip.
For most user, change image is expect as reinstall the system, but not re-create an instance.

I agree with you if user manage instance by UI, but this is terraform, we treat infra as cattle not pets, at least we can have a switch to decide "recreate" or not.

Thanks for your advise.

[yongzhang]

@likexian @ausmartway Cool, thanks.

[likexian]

#101

[likexian]

@hiscal2015
This has been fixed in v1.15.1, please upgrade and have a try.

[yongzhang]

@hiscal2015
This has been fixed in v1.15.1, please upgrade and have a try.

Thanks for fixing this!