Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command sequence check validation message #2460

Closed
wxing1292 opened this issue Feb 4, 2022 · 1 comment
Closed

Improve command sequence check validation message #2460

wxing1292 opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@wxing1292
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Command checks error message within workflow task handler should be improved.

Describe the solution you'd like
3rd party SDK may sometimes respond other command after terminal commands, e.g.

GRPC::InvalidArgument: 3:encouter invalid commands sequence: ContinueAsNewWorkflowExecution, ScheduleActivityTask, RecordMarker

consider reword the above error message to

Invalid command sequence.  Encountered commands ScheduleActivityTask, RecordMarker after command ContinueAsNewWorkflowExecution , which must be the last command in a workflow execution.
@wxing1292 wxing1292 added the enhancement New feature or request label Feb 4, 2022
@yiminc yiminc self-assigned this Feb 4, 2022
@yiminc yiminc closed this as completed Feb 12, 2022
@yiminc
Copy link
Member

yiminc commented Feb 12, 2022

#2468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants