Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not every commit is picked up by PR resource #144

Closed
bhutkovskyysos opened this issue Aug 26, 2019 · 4 comments
Closed

Not every commit is picked up by PR resource #144

bhutkovskyysos opened this issue Aug 26, 2019 · 4 comments

Comments

@bhutkovskyysos
Copy link

My pipeline is using PR resource and I noticed so far that not every commit is picked up to trigger it. I have my resource set to check_every: 10s, but if there are multiple commits in that time period it will only pick up the latest one. Is this intended behavior? Since the resource itself is not picking up all the commits version: every doesn't give a lot of value to my job.

@itsdalmo
Copy link
Contributor

itsdalmo commented Sep 4, 2019

Hi @bhutkovskyysos, and sorry for the late response. What you describe is the intended behaviour, i.e. the resource will only produce a new version for the latest commit per open PR. The "per open PR" is where version: every comes in and ensures that if a check returns the latest commit from 2 or more open pull requests, it will trigger a build for all of them, and not just the most recently updated pull request.

This is unfortunately how the resource will have to work until Concourse supports "spaces" or some similar way of tracking multiple commits in multiple PRs.

@phillbaker
Copy link

@itsdalmo just curious if you think this resource will address the issue described in concourse/concourse#736, where version: every will skip versions if a parallel upstream job's latest build finishes before an older one?

@itsdalmo
Copy link
Contributor

@phillbaker the issue you linked seems to affect any resource in Concourse, as long as passed: is used in combination with version: every. I.e., github-pr-resource will be affected as well.

@itsdalmo
Copy link
Contributor

I will close this issue as the original question has been answered and it has gone stale :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants