Logging revamp in general #221
Labels
core/config
Anything dealing with the configuration subsystem
core/docs
Core documentation, either actual documentation of technical tooling for documentation
core/modules
Anything dealing with the general module support
enhancement
New feature or request
question
Any question related to Skogul, how it works, "is this the intended behaviour" etc.
This is a "dev-note"/discussion issue. Please add ANY AND ALL feedback even remotely related to logging here, unless there is already an obvious issue that covers it (e.g. #70). I am trying to get a good overall logging approach.
We introduced logrus to standardize logging, but I'm honestly not very impressed. So far, the main benefit is implementing log levels. For actual logs, the output tends to be a bit convulted for my taste, and it's difficult to write clean code that gracefully handles nested error situations.
In Logrus' defence, since it's creation, wrapped error messages have become a real thing that actually works.
In addition to this, the skogul.Error{} data type doesn't really do us any favors. The idea might've been sensible, but it never materialized. As such, I am gradually removing it as I'm working with the code.
I am not entirely giving up on logrus, but this issue is left as a little "dev note". I am currently focusing on cleaning up our actual real life logs and making them useful for debugging. To a large extent, this means reducing reliance on logrus "fields", and instead using fairly plain text log messages, wrapped.
A few notes, also found in docs/:
The text was updated successfully, but these errors were encountered: