Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing a storage migration job that users can run after an upgrade. #1224

Open
vaikas opened this issue Sep 9, 2021 · 8 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@vaikas
Copy link
Contributor

vaikas commented Sep 9, 2021

Feature request

Consider providing a tool for upgrading the stored versions on the API server for various versions.

Use case

For example, EventListener has two supported API versions, v1alpha1 and v1beta1
https://github.com/tektoncd/triggers/blob/main/config/300-eventlistener.yaml#L74
https://github.com/tektoncd/triggers/blob/main/config/300-eventlistener.yaml#L39

At any given time only one storage version is supported by the CRD configuration like above. However, if there's a cluster that started with storage v1alpha1, then v1beta1 was introduced, the cluster will have a mixed versions stored in the API server.

This is fine however, as mentioned in the #1223 we should provide a conversion webhook that means a user can request either version and the correct version is returned even if the schemas are different.

As part of the cleanups however, the previous storage versions should be upgraded so that eventually we could drop the previously supported versions (say, like v1alpha1 at some point should probably deprecated and removed?). As per:

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#previous-storage-versions

there's a tool that users could run. However, in Knative, we decided to have tools (k8s jobs) that would at each release upgrade the necessary storage versions. Just wanted to throw this out there, since it seemed to resonate with users.

One such example is here:
knative/eventing#3168

@vaikas vaikas added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2021
@vdemeester
Copy link
Member

cc @tektoncd/core-maintainers too as this would apply to tektoncd/pipeline as well (and @tektoncd/operator-maintainers for the operator 😛 )

@vaikas
Copy link
Contributor Author

vaikas commented Sep 9, 2021

And the cool thing is that it should just be the matter of updating the list of resources that need to have their storages migrated like so:
https://github.com/knative/eventing/pull/3168/files#diff-f4f5ee556d4ac9c801a8248840b9d7bc522275086b72865457ba6074e6168d93R38

So no changes are required to add additional resources.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2021
@dibyom dibyom added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 8, 2021
@dibyom
Copy link
Member

dibyom commented Dec 8, 2021

/cc @jerop @lbernick - We'll need this if we ever plan to drop the v1alpha1 version in pipelines.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 7, 2022
@dibyom dibyom removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 8, 2022
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2022
@vdemeester
Copy link
Member

/lifecycle frozen
I think it still needs to be fixed 👼🏼

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

4 participants