From 5651f00a986d5ac1e580c175d846c4d7764d025a Mon Sep 17 00:00:00 2001 From: Enrique Encalada Date: Fri, 4 Dec 2020 10:21:32 +0100 Subject: [PATCH] Enhance enabling-ha.md doc This document was missing the `data.buckets` configurable parameter for the leader election. Remove references to `data.resourceLock` for HA config While enhancing the HA document, we realized that the `resourceLock`` field is not configurable in the Knative side, but rather hardcoded. You can see in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L74-L87 , where the Config object is defined, that this field is not included. Also, the value for it seems to be hardcoded to "leases", as seen in https://github.com/knative/pkg/blob/master/leaderelection/config.go#L38 Signed-off-by: Zoe --- config/config-leader-election.yaml | 1 - docs/enabling-ha.md | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/config-leader-election.yaml b/config/config-leader-election.yaml index cec52e4c923..2ada19bfb58 100644 --- a/config/config-leader-election.yaml +++ b/config/config-leader-election.yaml @@ -22,7 +22,6 @@ metadata: app.kubernetes.io/part-of: tekton-pipelines data: # An inactive but valid configuration follows; see example. - resourceLock: "leases" leaseDuration: "15s" renewDeadline: "10s" retryPeriod: "2s" diff --git a/docs/enabling-ha.md b/docs/enabling-ha.md index ad87431a22f..40fdf375be9 100644 --- a/docs/enabling-ha.md +++ b/docs/enabling-ha.md @@ -36,11 +36,13 @@ The leader election can be configured via the [config-leader-election.yaml](../. | Parameter | Default | | -------------------- | -------- | -| `data.resourceLock` | "leases" | +| `data.buckets` | 1 | | `data.leaseDuration` | 15s | | `data.renewDeadline` | 10s | | `data.retryPeriod` | 2s | +_Note_: When setting `data.buckets`, the underlying Knative library only allows a value between 1 and 10, making 10 the maximum number of allowed buckets. + ## Disabling leader election ---