Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client/server compatibility tests #5782

Closed
1 task
Tracked by #6870
JeromeJu opened this issue Nov 22, 2022 · 4 comments · Fixed by #6896
Closed
1 task
Tracked by #6870

Add client/server compatibility tests #5782

JeromeJu opened this issue Nov 22, 2022 · 4 comments · Fixed by #6896
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 22, 2022

This issue tracks the improvement of upgrade test for preventing regression as noted in #5193:

Recently, we have had a few issues of regressions that were not detected by CI.

For example, https://github.com/tektoncd/pipeline/pull/4834 introduced changes that caused a new client to be incompatible with an old server.

In addition, some breaking changes were introduced where resources already stored on a cluster became invalid when the server version was upgraded. https://github.com/tektoncd/pipeline/pull/4779 added new defaults via the mutating webhook, and then https://github.com/tektoncd/pipeline/pull/4818 validated the existence of these defaults. However, existing resources didn't receive these defaults, so they failed validation.

We should add a step where we run integration tests on the older server version (before upgrading the server). This will address the first type of regression detailed here. When we do make a breaking change purposefully (after deprecating a field), I would imagine we'd remove tests for this functionality, so I don't think adding this check would stop us from removing deprecated fields.

@JeromeJu JeromeJu added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2022
@JeromeJu
Copy link
Member Author

/assign

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2023
@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2023
@dibyom
Copy link
Member

dibyom commented May 18, 2023

the first type of regression detailed here.

@JeromeJu could you describe what the regression we are trying to catch is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Status: Done
5 participants