From 3dfea627ed170798ff5fb98aa1c76f532edca276 Mon Sep 17 00:00:00 2001
From: Shuhei Kitagawa <shuhei.kitagawa@c-fo.com>
Date: Mon, 17 Jun 2019 10:00:00 +0900
Subject: [PATCH] Add tests for system/names

---
 pkg/system/names.go      |  2 +-
 pkg/system/names_test.go | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 pkg/system/names_test.go

diff --git a/pkg/system/names.go b/pkg/system/names.go
index e4c2fec684e..6af551a1c5b 100644
--- a/pkg/system/names.go
+++ b/pkg/system/names.go
@@ -29,5 +29,5 @@ func GetNamespace() string {
 	if systemNamespace == "" {
 		return DefaultNamespace
 	}
-	return os.Getenv(SystemNamespaceEnvVar)
+	return systemNamespace
 }
diff --git a/pkg/system/names_test.go b/pkg/system/names_test.go
new file mode 100644
index 00000000000..a1bbe1b3991
--- /dev/null
+++ b/pkg/system/names_test.go
@@ -0,0 +1,35 @@
+package system
+
+import (
+	"os"
+	"testing"
+)
+
+func Test_GetNamespace(t *testing.T) {
+	testcases := []struct {
+		envVar       string
+		expectEnvVar string
+	}{
+		{
+			envVar:       "",
+			expectEnvVar: DefaultNamespace,
+		},
+		{
+			envVar:       "test",
+			expectEnvVar: "test",
+		},
+	}
+
+	value := os.Getenv(SystemNamespaceEnvVar)
+	defer func() { os.Setenv(SystemNamespaceEnvVar, value) }()
+
+	for _, ts := range testcases {
+		if err := os.Setenv(SystemNamespaceEnvVar, ts.envVar); err != nil {
+			t.Fatalf("Failed to set ENV: %v", err)
+		}
+
+		if got, want := GetNamespace(), ts.expectEnvVar; got != want {
+			t.Fatalf("Invalid namespace: got: %v, want: %v", got, want)
+		}
+	}
+}