From 054702b16ade3b21c2a2eed032d3da3183640070 Mon Sep 17 00:00:00 2001 From: Vincent Demeester Date: Tue, 4 Dec 2018 11:53:49 +0100 Subject: [PATCH] =?UTF-8?q?Remove=20default=20namespace=20from=20samples?= =?UTF-8?q?=20=F0=9F=98=85?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It feels really weird to try running the example on a different namespace and not see them because the namespace is *hard-coded* in the sample yaml. Signed-off-by: Vincent Demeester --- examples/build-task.yaml | 3 +-- examples/default-cluster-admin.yaml | 2 +- examples/deploy-task.yaml | 3 +-- examples/output-pipeline.yaml | 3 +-- examples/output-tasks.yaml | 2 -- examples/pipeline.yaml | 1 - examples/resources.yaml | 5 +---- examples/run/output-pipeline-run.yaml | 3 +-- examples/run/pipeline-run.yaml | 3 +-- 9 files changed, 7 insertions(+), 18 deletions(-) diff --git a/examples/build-task.yaml b/examples/build-task.yaml index 2769fcb163c..3c29f362926 100644 --- a/examples/build-task.yaml +++ b/examples/build-task.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Task metadata: name: build-push - namespace: default spec: inputs: resources: @@ -27,4 +26,4 @@ spec: args: - --dockerfile=${inputs.params.pathToDockerFile} - --destination=${outputs.resources.builtImage.url} - - --context=${inputs.params.pathToContext} \ No newline at end of file + - --context=${inputs.params.pathToContext} diff --git a/examples/default-cluster-admin.yaml b/examples/default-cluster-admin.yaml index 9bbdf07ad57..ee21f9e349c 100644 --- a/examples/default-cluster-admin.yaml +++ b/examples/default-cluster-admin.yaml @@ -9,4 +9,4 @@ subjects: roleRef: kind: ClusterRole name: cluster-admin - apiGroup: rbac.authorization.k8s.io \ No newline at end of file + apiGroup: rbac.authorization.k8s.io diff --git a/examples/deploy-task.yaml b/examples/deploy-task.yaml index 0dcd53c4e77..4468ea48267 100644 --- a/examples/deploy-task.yaml +++ b/examples/deploy-task.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Task metadata: name: demo-deploy-kubectl - namespace: default spec: inputs: resources: @@ -37,4 +36,4 @@ spec: args: - 'apply' - '-f' - - '${inputs.params.path}' \ No newline at end of file + - '${inputs.params.path}' diff --git a/examples/output-pipeline.yaml b/examples/output-pipeline.yaml index 9244e7b20a7..fdc96b6cf23 100644 --- a/examples/output-pipeline.yaml +++ b/examples/output-pipeline.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Pipeline metadata: name: output-pipeline - namespace: default spec: tasks: - name: first-create-file # 1. create file @@ -13,4 +12,4 @@ spec: name: check-stuff-file-exists resources: - name: workspace - providedBy: [first-create-file] \ No newline at end of file + providedBy: [first-create-file] diff --git a/examples/output-tasks.yaml b/examples/output-tasks.yaml index 9dabcffbd12..772b6b45267 100644 --- a/examples/output-tasks.yaml +++ b/examples/output-tasks.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Task metadata: name: create-file - namespace: default spec: inputs: resources: @@ -28,7 +27,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Task metadata: name: check-stuff-file-exists - namespace: default spec: inputs: resources: diff --git a/examples/pipeline.yaml b/examples/pipeline.yaml index a817b856513..f98d2aff4ed 100644 --- a/examples/pipeline.yaml +++ b/examples/pipeline.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: Pipeline metadata: name: demo-pipeline - namespace: default spec: tasks: - name: build-skaffold-web diff --git a/examples/resources.yaml b/examples/resources.yaml index 5e2e7669723..47be0331d89 100644 --- a/examples/resources.yaml +++ b/examples/resources.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: PipelineResource metadata: name: skaffold-git - namespace: default spec: type: git params: @@ -15,7 +14,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: PipelineResource metadata: name: skaffold-image-leeroy-web - namespace: default spec: type: image params: @@ -26,9 +24,8 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: PipelineResource metadata: name: skaffold-image-leeroy-app - namespace: default spec: type: image params: - name: url - value: gcr.io/christiewilson-catfactory/leeroy-app \ No newline at end of file + value: gcr.io/christiewilson-catfactory/leeroy-app diff --git a/examples/run/output-pipeline-run.yaml b/examples/run/output-pipeline-run.yaml index c288ce3fe31..34fccaff948 100644 --- a/examples/run/output-pipeline-run.yaml +++ b/examples/run/output-pipeline-run.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: PipelineRun metadata: name: output-pipeline-run - namespace: default spec: pipelineRef: name: output-pipeline @@ -26,4 +25,4 @@ spec: inputs: - name: workspace resourceRef: - name: skaffold-git \ No newline at end of file + name: skaffold-git diff --git a/examples/run/pipeline-run.yaml b/examples/run/pipeline-run.yaml index 842508dcc41..4ee66903392 100644 --- a/examples/run/pipeline-run.yaml +++ b/examples/run/pipeline-run.yaml @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1 kind: PipelineRun metadata: name: demo-pipeline-run-1 - namespace: default spec: pipelineRef: name: demo-pipeline @@ -46,4 +45,4 @@ spec: name: skaffold-git - name: image resourceRef: - name: skaffold-image-leeroy-web \ No newline at end of file + name: skaffold-image-leeroy-web