Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of Tekton Dashboard service url content path #3606

Closed
Romanecek opened this issue Sep 14, 2024 · 2 comments · Fixed by #3614
Closed

Configuration of Tekton Dashboard service url content path #3606

Romanecek opened this issue Sep 14, 2024 · 2 comments · Fixed by #3614
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Romanecek
Copy link

Romanecek commented Sep 14, 2024

Feature request

Consider url content path when calling Tekton Dashboard service API

Use case

Tekton Dashboard service might be exposed on nonroot content path for example https://my-server/ci/tekton .
When falling back for external logs the API call from browser is made to https://my-server/v1/logs-proxy instead of https://my-server/ci/tekton/v1/logs-proxy .

It would be helpful to have a configuration property to specify the correct path for API calls.

Alternatives

Here I created some raw solution which works for as at this moment: #3607

@Romanecek Romanecek added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2024
@AlanGreene AlanGreene self-assigned this Sep 16, 2024
@AlanGreene AlanGreene added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 16, 2024
@AlanGreene
Copy link
Member

Thanks for raising this @Romanecek. It's actually a bug in the client. For some reason the external logs requests weren't using the correct context root like other APIs. PR opened to address this: #3614

@AlanGreene
Copy link
Member

Fix is available in the latest nightly release:

It will be included in v0.51.0 due in the next ~1-2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants