Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additions to context made by adjust rules for follow-up rules #2706

Open
happz opened this issue Feb 22, 2024 · 2 comments
Open

Support additions to context made by adjust rules for follow-up rules #2706

happz opened this issue Feb 22, 2024 · 2 comments
Labels
area | context The context adjust implementation status | discuss Needs more discussion before closing

Comments

@happz
Copy link
Collaborator

happz commented Feb 22, 2024

adjust:
  - when: distro == rhel-9
    context+:
      llvm: 19

  - when: llvm == 19
    ...

Since fmf does not recognize context, this might need a combined effort of tmt and tmt, e.g. fmf accepting a callback updating context, or a list of keys affecting context...

No idea how messy this can get. Plus, I recall seeing similar questions in the past, there might be issues with discussions somewhere. Yet, it might be nice to give it more thought.

@happz happz added the area | context The context adjust implementation label Feb 22, 2024
@lukaszachy lukaszachy added the status | discuss Needs more discussion before closing label Feb 22, 2024
@happz happz changed the title Support additionas to context made by adjust rules for follow-up rules Support additions to context made by adjust rules for follow-up rules Feb 22, 2024
@kwk
Copy link

kwk commented Feb 22, 2024

Just to give some context. This discussion came up here: https://src.fedoraproject.org/tests/lld/pull-request/5#c-6be99873e606937bdf7d3bbc29d42c98b8e9163f-26

@happz
Copy link
Collaborator Author

happz commented Feb 27, 2024

Filed teemtee/fmf#222 for the change, this would need to happen in fmf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | context The context adjust implementation status | discuss Needs more discussion before closing
Projects
None yet
Development

No branches or pull requests

3 participants