Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Convert to ember-deploy adapter #11

Open
lukemelia opened this issue Feb 23, 2015 · 3 comments
Open

Convert to ember-deploy adapter #11

lukemelia opened this issue Feb 23, 2015 · 3 comments

Comments

@lukemelia
Copy link

Are there any blockers (technical or philosophical) to converting this to be an ember-deploy adapter? /cc @LevelbossMike

@LevelbossMike
Copy link

I didn't look into this in detail but if the only thing that we need to do is call an api endpoint to notify some service about a new upload this can be done via an ember-deploy adapter. This could also be improved by adding some notification hooks to ember-deploy directly so it is easier to do something like this. would also be useful for hubot integration or slack notifications etc. @lukemelia

@samselikoff
Copy link
Contributor

Hey hey, yep this was the original plan, I think it started out as a fork of ember-deploy and then we just changed it to suit our purposes for the time being. We wanted to get a proof of concept out + adapters weren't yet part of ember-deploy, so that's why we changed.

We should absolutely turn this into an ember-deploy adapter, so I'll leave this issue open. Thanks!

@samselikoff samselikoff changed the title convert to ember-deploy adapter? Convert to ember-deploy adapter Feb 23, 2015
@hhff
Copy link
Contributor

hhff commented Feb 23, 2015

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants