-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argon2::Password.hash overrides Object#hash in an incompatible manner #9
Comments
I could change the hash function to "create" in line with other similar gems. However, this would be a breaking change. Therefore I would have to ask, is the above code something you would ever write in practice? |
Yup. I use a hash to cache class names here: https://github.com/dgutov/robe/blob/master/lib/robe/sash.rb#L38 It's a dynamic code assistance tool. |
Sounds like I'm sold. Incoming fix. |
This requires an obvious version bump. I've done so in the source, I'll let it settle a few days before tagging a release. |
Thanks! |
Which makes it impossible to use the class as a key in a hash, for instance:
The text was updated successfully, but these errors were encountered: