Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Detects microG on a deGoogled CalyxOS device #53

Open
StellarSand opened this issue Jan 22, 2025 · 17 comments
Open

[Issue]: Detects microG on a deGoogled CalyxOS device #53

StellarSand opened this issue Jan 22, 2025 · 17 comments
Labels
bug Something isn't working

Comments

@StellarSand
Copy link
Collaborator

StellarSand commented Jan 22, 2025

Hi, after updating to 2.1.0 the issue is still present.

Originally posted by @CristianKerr in #46

TL;DR:

  • Device has deGoogled main profile
  • microG is installed in work profile
  • App detects the device as microG on main profile

My test results

@CristianKerr's test results

@StellarSand StellarSand added the bug Something isn't working label Jan 22, 2025
@StellarSand
Copy link
Collaborator Author

@CristianKerr was v2.0.7 working fine for you?

@CristianKerr
Copy link

CristianKerr commented Jan 22, 2025

I think I never had 2.0.7, I first installed the day I reported/commented the issue an it was already not working. I am not sure which version was it.

@CristianKerr
Copy link

I just installed 2.0.7 and it is not working either.

@StellarSand
Copy link
Collaborator Author

I'm pretty sure it's not an issue with the app (it could be, but I'm pretty sure it's not). Could you please check if microG is somehow present but disabled in the main profile?

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Jan 22, 2025

https://gitlab.com/CalyxOS/calyxos/-/issues/2972

Also, meant to send these replies: #46 (comment) here, not there

@StellarSand
Copy link
Collaborator Author

Yeah so it's still installed but disabled and therefore it will always be detected by other apps.

@lucasmz-dev
Copy link
Contributor

Could the check be changed to checked if it's disabled or not?

@CristianKerr
Copy link

@StellarSand sorry I am away I will look into the packages as soon as possible.

This is why I think there could be somewhere option to change this, maybe even a little bit hidden (or with a text "I solemnly swear..." if you are afraid people would misuse this. I think that some trust in the community would be fine, we are people who install custom roms I think nobody has an interest in malicious acting. (Please don't take me wrong, I respect your choice 😊 I am just trying to argument a little bit here.)

The issue is if I send my reports now, it will be misrepresented. And I so want to share my experience with the application 😊

@StellarSand
Copy link
Collaborator Author

StellarSand commented Jan 24, 2025

Could the check be changed to checked if it's disabled or not?

Yes I can make an exception for CalyxOS and treat disabled microG as deGoogled, but I'll wait for someone from CalyxOS team to reply to your issue first. Based on their response I'll make further changes in the app.

This is why I think there could be somewhere option to change this, maybe even a little bit hidden (or with a text "I solemnly swear..." if you are afraid people would misuse this. I think that some trust in the community would be fine, we are people who install custom roms I think nobody has an interest in malicious acting.

The reason I’ve stuck with auto-detection is that it has worked well across all ROMs (with the occasional times where it was incorrectly detecting due to my code mistakes, but was fixed as they happened), and this specific case with CalyxOS is the first time something like this has popped up.

I agree that the community is trustworthy, and I value that, but I believe it’s important to keep things as seamless, accurate & consistent as possible for everyone using the app. There could be other ways to handle this specific edge case (like treating disabled microG as deGoogled on CalyxOS), and I’m definitely open to exploring them. If I hit a point where there’s no better way to handle it, I will definitely consider adding an option to let users manually select the config.

@StellarSand
Copy link
Collaborator Author

I’d appreciate your help in testing a theory. If both Plexus and APK Explorer & Editor are detecting microG in the main profile, it’s possible that other apps might also detect it, unless they specifically filter out disabled apps (microG apps in this case).

Could you try testing a few apps you know have issues on degoogled devices but work well with microG? I’ll test them on an actual degoogled device, and you can test on CalyxOS. Then, we can compare our results.

@CristianKerr
Copy link

@StellarSand Ah yes, I am back, sorry forgot about it. Can you please tell me what exactly to do and check? Maybe write down your steps and I will copy them on my device.

I agree that the community is trustworthy, and I value that, but I believe it’s important to keep things as seamless, accurate & consistent as possible for everyone using the app. There could...

I understand, thank you for explanation 😊 I hope we will manage to find good solution 👍

@CristianKerr
Copy link

btw these are all my disabled packages:

package:com.google.android.gsf
package:com.android.vending
package:app.seamlessupdate.client
package:com.google.android.gms
package:com.android.messaging

(which you already probably expected, but I wanted to confirm)

@lucasmz-dev
Copy link
Contributor

package:app.seamlessupdate.client

did you mean to disable the updater, you won't be getting updates

@CristianKerr
Copy link

CristianKerr commented Jan 27, 2025

I didn't change this (not manually). And I am actually getting updates. But what I have (and its probably that) is that I don't have them auto install/restart. I always have notification about a new update and I click on a button there when I want to apply/restart.

@lucasmz-dev
Copy link
Contributor

It's really weird to me that it is disabled. This is the system updater and it isn't disabled on my install.

You should be able to enable automatic restarts on Settings > System > System updates > Automatic restart

@CristianKerr
Copy link

But I don't want that, I want to have a control over when I apply the update. I did set it in that menu. What I wanted to say is that I didn't change it via adb.

@lucasmz-dev
Copy link
Contributor

That's fine, but still it shouldn't be disabled. I just tested and it's possible to disable it without ADB, anyway, it seems that disabling it hides that menu with those options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants