Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltHelper and gtHelper third argument bug #363

Closed
alexandernst opened this issue Feb 28, 2016 · 1 comment
Closed

ltHelper and gtHelper third argument bug #363

alexandernst opened this issue Feb 28, 2016 · 1 comment

Comments

@alexandernst
Copy link
Collaborator

The third argument of both functions is returned without being defaulted. This means that the functions are returning "undefined" (sometimes) when they should be returning "false".

Unless strict "if" statements are used with those helper functions, the code will work as expected, but I feel this is kind of dirty.

Should I submit a PR to default the third argument to false? (arg3 = arg3 || false will do it)

@obeliskos

@alexandernst
Copy link
Collaborator Author

This should get fixed by #365
I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant