You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The third argument of both functions is returned without being defaulted. This means that the functions are returning "undefined" (sometimes) when they should be returning "false".
Unless strict "if" statements are used with those helper functions, the code will work as expected, but I feel this is kind of dirty.
Should I submit a PR to default the third argument to false? (arg3 = arg3 || false will do it)
The third argument of both functions is returned without being defaulted. This means that the functions are returning "undefined" (sometimes) when they should be returning "false".
Unless strict "if" statements are used with those helper functions, the code will work as expected, but I feel this is kind of dirty.
Should I submit a PR to default the third argument to
false
? (arg3 = arg3 || false
will do it)@obeliskos
The text was updated successfully, but these errors were encountered: