Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify breaks setters with unused arguments #481

Closed
Arkerthan opened this issue Apr 28, 2022 · 1 comment
Closed

Minify breaks setters with unused arguments #481

Arkerthan opened this issue Apr 28, 2022 · 1 comment

Comments

@Arkerthan
Copy link

Take this valid javascript:

class Test {
	set x(e) {
		throw  Error("Operation not supported");
	}
}

It minifies to class Test{set x(){throw Error("Operation not supported")}}, expanded:

class Test {
	set x() {
		throw Error("Operation not supported");
	}
}

which is invalid javascript.

@tdewolff
Copy link
Owner

tdewolff commented May 2, 2022

Thanks for the report, should be fixed now on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants