Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test class instantiation is redundantly verbose #77

Closed
KubaO opened this issue Dec 5, 2019 · 1 comment
Closed

Test class instantiation is redundantly verbose #77

KubaO opened this issue Dec 5, 2019 · 1 comment

Comments

@KubaO
Copy link
Contributor

KubaO commented Dec 5, 2019

FB_PrimitiveTypes primitiveTypes = new FB_PrimitiveTypes(errorItems, "PrimitiveTypes"); is a bit much :)

I'd expect new FB_PrimitiveTypes(errorItems); to be enough - the class name is available via reflection, and the explicit variable name and type are unnecessary.
@sagatowski
Copy link
Member

Merged into commit b157437.

@sagatowski sagatowski transferred this issue from another repository Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KubaO @sagatowski