Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON Schema Store to include projectBaseUrl #355

Closed
wesley-dean-gsa opened this issue Aug 5, 2024 · 2 comments
Closed

Update JSON Schema Store to include projectBaseUrl #355

wesley-dean-gsa opened this issue Aug 5, 2024 · 2 comments

Comments

@wesley-dean-gsa
Copy link

Bonjour hi,

While using v8r through MegaLinter, I started receiving the following error message:

ℹ No config file found
ℹ Processing ./.markdown-link-check.json
ℹ Found schema in https://www.schemastore.org/api/json/catalog.json ...
ℹ Validating ./.markdown-link-check.json against schema from https://json.schemastore.org/markdown-link-check.json ...
✖ ./.markdown-link-check.json is invalid

./.markdown-link-check.json# must NOT have additional properties

The JSON file being validated is:

{
  "retryOn429": true,
  "retryCount": 5,
  "aliveStatusCodes": [
    200,
    203,
    206
  ],
  "projectBaseUrl": "https://github.com/org/repo/",
  "ignorePatterns": [
    {
      "pattern": "^https?://github.com/"
    }
  ]
}

I then went to the markdown-link-check entry on SchemaStore and noticed that the projectBaseUrl item isn't present. I was expecting to see something like:

    "projectBaseUrl": {
      "type": "string"
    },

The markdown-link-check.json file is hosted on GitHub.

@wesley-dean-gsa
Copy link
Author

wesley-dean-gsa commented Aug 5, 2024

@tcort, I submitted a PR to address this: SchemaStore/schemastore#3972

If you disagree with what I submitted or if you would rather submit something your self, that's totally cool with me. If you want to drop a comment on the PR as the author of the tool, I'm pretty sure it wouldn't hurt.

@wesley-dean-gsa
Copy link
Author

SchemaStore/schemastore#3972 has been merged and the aforementioned .markdown-link-check.json with the projectBaseUrl field validates properly.

ℹ No config file found
ℹ Processing ./.markdown-link-check.json
ℹ Found schema in https://www.schemastore.org/api/json/catalog.json ...
ℹ Validating ./.markdown-link-check.json against schema from https://json.schemastore.org/markdown-link-check.json ...
✔ ./.markdown-link-check.json is valid

Thank you for your most excellent tool and all of your hard word. Folks like you who put so much time and effort into good tooling are the unsung heroes of IT world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant