Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Promise.try tests #4069

Merged
merged 1 commit into from
May 14, 2024
Merged

add Promise.try tests #4069

merged 1 commit into from
May 14, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented May 1, 2024

@ljharb ljharb requested review from a team as code owners May 1, 2024 22:27
@ljharb ljharb mentioned this pull request May 1, 2024
Closed
31 tasks
gibson042
gibson042 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo better use of helpers.

test/built-ins/Promise/try/args.js Outdated Show resolved Hide resolved
test/built-ins/Promise/try/throws.js Outdated Show resolved Hide resolved
@ljharb ljharb requested review from jridgewell, ckknight and a team and removed request for ckknight May 11, 2024 06:25
@ptomato
Copy link
Contributor

ptomato commented May 14, 2024

Is this waiting for another review? Happy to oblige but it looks like it's already got plenty...

OK with me to just fix the linter errors and merge it. (looks like it needs 3x flags: [async] instead of features: [async])

@ljharb
Copy link
Member Author

ljharb commented May 14, 2024 •
edited
Loading

i'll fix that and then land it :-)

@ljharb ljharb force-pushed the promise.try branch 2 times, most recently from 15c96ed to 8b6b0f5 Compare May 14, 2024 22:03
@ljharb ljharb merged commit 8b6b0f5 into main May 14, 2024
8 checks passed
@ljharb ljharb deleted the promise.try branch May 14, 2024 22:10
@JLHwung JLHwung mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckknight ckknight ckknight left review comments

@gibson042 gibson042 gibson042 approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljharb @ptomato @ckknight @jridgewell @gibson042