Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to add test for GetOptionsObject of Intl.DisplayNames, Intl.ListFormat and Intl.Segmenter #2950

Closed
FrankYFTang opened this issue Feb 18, 2021 · 1 comment · Fixed by #2952
Closed

Need to add test for GetOptionsObject of Intl.DisplayNames, Intl.ListFormat and Intl.Segmenter #2950

FrankYFTang opened this issue Feb 18, 2021 · 1 comment · Fixed by #2952

Comments

@FrankYFTang
Copy link
Contributor

Differ from older Intl API, newer Intl APIs use GetOptionsObject and we need add tests to verify that.

Spec change in https://github.com/tc39/ecma402/pull/538/files
@FrankYFTang FrankYFTang mentioned this issue Feb 18, 2021
Open
@FrankYFTang
Copy link
Contributor Author

The following tests which assume the ToObject are used also need to be modified
intl402/Segmenter/constructor/constructor/options-toobject.js
intl402/Segmenter/constructor/constructor/options-toobject-prototype.js
intl402/ListFormat/constructor/constructor/options-toobject.js
intl402/ListFormat/constructor/constructor/options-toobject-prototype.js

@FrankYFTang FrankYFTang mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Intl.(ListFormat|DisplayNames|Segmenter) FrankYFTang/test262
1 participant
@FrankYFTang