Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 402 version of IsBuiltinCalendar #1869

Closed
FrankYFTang opened this issue Oct 13, 2021 · 2 comments
Closed

Improve 402 version of IsBuiltinCalendar #1869

FrankYFTang opened this issue Oct 13, 2021 · 2 comments

Comments

@FrankYFTang
Copy link
Contributor

The "15.6.1.1 IsBuiltinCalendar ( id )" say the following
"
This definition supersedes the definition provided in 12.1.2.

  1. Let builtinCalendars be a List of Unicode BCP 47 calendar identifiers identifying the calendars for which the implementation provides the functionality of the constructed Temporal.Calendar objects. The list must include "iso8601". The ordering is irrelevant.
    "
    The problem is the term "Unicode BCP 47 calendar identifiers" is not clearly defined here. I suggest we made a editoral changes as below:

https://tc39.es/proposal-temporal/#sup-temporal-isbuiltincalendar

"
This definition supersedes the definition provided in 12.1.2. The following algorithm refers to UTS 35's Unicode BCP 47 U Extension.

  1. Let builtinCalendars be a List of Unicode BCP 47 calendar identifiers identifying the calendars for which the implementation provides the functionality of the constructed Temporal.Calendar objects. The list must include "iso8601". The ordering is irrelevant.
    "
@FrankYFTang
Copy link
Contributor Author

or maybe it should juse use

Let builtinCalendars be AvailableCalendars ( ).

see https://tc39.es/proposal-intl-enumeration/#sec-availablecalendars
since proposal-intl-enumeration is already Stage 3

@ptomato
Copy link
Collaborator

ptomato commented Oct 15, 2021

I agree, using AvailableCalendars seems like the best way to do this. Thanks for pointing it out, as I wasn't aware it existed!

Otherwise I think this is a duplicate of #541, so I'll close this one.

@ptomato ptomato closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants