Skip to content

Commit db9314c

Browse files
committed
Editorial: Assert AdjustDateDurationRecord in Duration.round()/total()
This was a mistake in #2943. _targetTime_.[[Days]] cannot exceed the original value of _duration_.[[Days]] here because its absolute value can only be equal or smaller coming out of AddTime.
1 parent 748f27f commit db9314c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

spec/duration.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ <h1>Temporal.Duration.prototype.round ( _roundTo_ )</h1>
444444
1. Let _targetTime_ be AddTime(0, 0, 0, 0, 0, 0, _normalizedDuration_.[[NormalizedTime]]).
445445
1. Let _isoRelativeToDate_ be TemporalObjectToISODateRecord(_plainRelativeTo_).
446446
1. Let _calendar_ be _plainRelativeTo_.[[Calendar]].
447-
1. Let _dateDuration_ be ? AdjustDateDurationRecord(_normalizedDuration_.[[Date]], _targetTime_.[[Days]]).
447+
1. Let _dateDuration_ be ! AdjustDateDurationRecord(_normalizedDuration_.[[Date]], _targetTime_.[[Days]]).
448448
1. Let _targetDate_ be ? CalendarDateAdd(_calendar_, _isoRelativeToDate_, _dateDuration_, *"constrain"*).
449449
1. Let _roundRecord_ be ? DifferencePlainDateTimeWithRounding(_isoRelativeToDate_.[[Year]], _isoRelativeToDate_.[[Month]], _isoRelativeToDate_.[[Day]], 0, 0, 0, 0, 0, 0, _targetDate_.[[Year]], _targetDate_.[[Month]], _targetDate_.[[Day]], _targetTime_.[[Hours]], _targetTime_.[[Minutes]], _targetTime_.[[Seconds]], _targetTime_.[[Milliseconds]], _targetTime_.[[Microseconds]], _targetTime_.[[Nanoseconds]], _calendar_, _largestUnit_, _roundingIncrement_, _smallestUnit_, _roundingMode_).
450450
1. Return _roundRecord_.[[Duration]].
@@ -486,7 +486,7 @@ <h1>Temporal.Duration.prototype.total ( _totalOf_ )</h1>
486486
1. Let _targetTime_ be AddTime(0, 0, 0, 0, 0, 0, _normalizedDuration_.[[NormalizedTime]]).
487487
1. Let _isoRelativeToDate_ be TemporalObjectToISODateRecord(_plainRelativeTo_).
488488
1. Let _calendar_ be _plainRelativeTo_.[[Calendar]].
489-
1. Let _dateDuration_ be ? AdjustDateDurationRecord(_normalizedDuration_.[[Date]], _targetTime_.[[Days]]).
489+
1. Let _dateDuration_ be ! AdjustDateDurationRecord(_normalizedDuration_.[[Date]], _targetTime_.[[Days]]).
490490
1. Let _targetDate_ be ? CalendarDateAdd(_calendar_, _isoRelativeToDate_, _dateDuration_, *"constrain"*).
491491
1. Let _roundRecord_ be ? DifferencePlainDateTimeWithRounding(_isoRelativeToDate_.[[Year]], _isoRelativeToDate_.[[Month]], _isoRelativeToDate_.[[Day]], 0, 0, 0, 0, 0, 0, _targetDate_.[[Year]], _targetDate_.[[Month]], _targetDate_.[[Day]], _targetTime_.[[Hour]], _targetTime_.[[Minute]], _targetTime_.[[Second]], _targetTime_.[[Millisecond]], _targetTime_.[[Microsecond]], _targetTime_.[[Nanosecond]], _calendar_, _unit_, 1, _unit_, *"trunc"*).
492492
1. Else,

0 commit comments

Comments
 (0)