Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs: (todo) default import.meta hook not specified #70

Closed
jfparadis opened this issue Aug 23, 2017 · 5 comments
Closed

Specs: (todo) default import.meta hook not specified #70

jfparadis opened this issue Aug 23, 2017 · 5 comments

Comments

@jfparadis
Copy link
Collaborator

The specification of ImportMetaHook is not complete. We could remove the code, or evolve the spec. Most likely, the behavior would mirror the import hook.

Here is a suggestion following HostGetImportMetaProperties:

11.2.2 Realm Default Import.Meta Hook Functions
A Realm default import.meta hook function is an anonymous built-in function.

When a Realm default meta import hook function is called with arguments moduleRecord, the following steps are taken:

  1. Return a new empty List.
    | NOTE
    | By default, newly created realms do not expose host specific behavior when evaluating import.meta calls.

And:

7.5 If importHook is undefined, then
a. Let importHook be a new built-in function object as defined in 11.2.2.

@caridy
Copy link
Collaborator

caridy commented Aug 24, 2017

I can't return a List. But overall, I'm ok with this removing this from now until that proposal reaches to stage 3.

@erights
Copy link
Collaborator

erights commented Feb 19, 2018

When "removing" this, please leave in place a comment with a TODO.

@ljharb
Copy link
Member

ljharb commented Feb 19, 2018

import.meta is already stage 3, so it probably shouldn't be removed at all at this point?

@erights
Copy link
Collaborator

erights commented Jul 4, 2018

#127 (comment) points out that import.meta only exists in module code, and so is not directly relevant to the Realms api. (I was confused about this until that comment.)

@jfparadis
Copy link
Collaborator Author

Closed. Issue not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants