Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeFormat FormatMatcher needs hourCycle in opt #511

Closed
longlho opened this issue Nov 9, 2020 · 0 comments · Fixed by #571
Closed

DateTimeFormat FormatMatcher needs hourCycle in opt #511

longlho opened this issue Nov 9, 2020 · 0 comments · Fixed by #571
Labels
c: datetime Component: dates, times, timezones s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request
Milestone
ES 2022

Comments

@longlho
Copy link
Collaborator

longlho commented Nov 9, 2020

Right now since opt does not have hourCycle/hour12 a 24hr-only format can have the same score as a 12hr format.

Reference bug: formatjs/formatjs#2291
@sffc sffc added c: datetime Component: dates, times, timezones s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request labels Apr 18, 2021
@sffc sffc added this to the ES 2022 milestone Apr 18, 2021
@longlho longlho mentioned this issue Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: datetime Component: dates, times, timezones s: help wanted Status: help wanted; needs proposal champion Small Smaller change solvable in a Pull Request
Projects
None yet
Milestone
ES 2022
Development

Successfully merging a pull request may close this issue.

Normative: Add hourCycle to opt before passing to FormatMatcher longlho/ecma402
2 participants
@longlho @sffc