actions: remove some events when disabling action

Close #404
taye · Aug 27, 2016 · cca4e26 · cca4e26
1 parent e29c1a3
commit cca4e26
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/src/actions/drag.js b/src/actions/drag.js
@@ -158,6 +158,10 @@ Interactable.prototype.draggable = function (options) {
   if (utils.isBool(options)) {
     this.options.drag.enabled = options;
 
+    if (!options) {
+      this.ondragstart = this.ondragstart = this.ondragend = null;
+    }
+
     return this;
   }
 

diff --git a/src/actions/drop.js b/src/actions/drop.js
@@ -346,6 +346,11 @@ Interactable.prototype.dropzone = function (options) {
   if (utils.isBool(options)) {
     this.options.drop.enabled = options;
 
+    if (!options) {
+      this.ondragenter = this.ondragleave = this.ondrop
+        = this.ondropactivate = this.ondropdeactivate = null;
+    }
+
     return this;
   }
 

diff --git a/src/actions/gesture.js b/src/actions/gesture.js
@@ -113,6 +113,10 @@ Interactable.prototype.gesturable = function (options) {
   if (utils.isBool(options)) {
     this.options.gesture.enabled = options;
 
+    if (!options) {
+      this.ongesturestart = this.ongesturestart = this.ongestureend = null;
+    }
+
     return this;
   }
 

diff --git a/src/actions/resize.js b/src/actions/resize.js
@@ -361,6 +361,10 @@ Interactable.prototype.resizable = function (options) {
   if (utils.isBool(options)) {
     this.options.resize.enabled = options;
 
+    if (!options) {
+      this.onresizestart = this.onresizestart = this.onresizeend = null;
+    }
+
     return this;
   }
   return this.options.resize;