Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Short and Long Version Strings out of Sync iOS #10830

Open
bradleat opened this issue Aug 30, 2024 · 0 comments
Open

[bug] Short and Long Version Strings out of Sync iOS #10830

bradleat opened this issue Aug 30, 2024 · 0 comments
Labels
platform: iOS status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@bradleat
Copy link

Describe the bug

The ios build step should update both version strings in the plist on ios. Currently it only updates one:

<key>CFBundleShortVersionString</key>
<string>0.1.0</string>
<key>CFBundleVersion</key>
<string>0.2.1</string>

Notice the CFBundleShortVersionString can get out of sync with CFBundleVersion

I'd like to make a fix (could be a first good issue), but I really can't tell when/where tauri is writing this during the build step.

What I can see is that is that this file:

plist.insert("CFBundleVersion".into(), build_number.into());
appear to write both the short version string and the bundle version, but from different sources.

Reproduction

  1. Build an ios app with a tauri.conf.json version string that points to to the project.json.

  2. Change the version.

  3. Notice that the CFBundleVersion updates but not the CFBundleShortVersionString

Expected behavior

Both version strings update, or the can be controlled seperately. Or perhaps the short version string is the x.y.z component of the bundle version which might include a canary.

Full tauri info output

N/A

Stack trace

No response

Additional context

No response

@bradleat bradleat added status: needs triage This issue needs to triage, applied to new issues type: bug labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: iOS status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

2 participants